fix: remove incorrect cents-to-dollars conversion in notification email formatting#13
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…il formatting Root cause: NotificationRenderer.FormatCurrency() was dividing the amount by 100, assuming TotalAmount was in cents. However, the OrderPlacedEvent contract and all producers send TotalAmount as a decimal in dollars (e.g. 149.99). The division caused 149.99 to display as $1.50 in order confirmation emails. Fix: Remove the / 100m division and format the amount directly, since it is already in dollars.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Order confirmation notification emails displayed incorrect amounts (e.g., a $149.99 order showed as $1.50).
Root cause:
NotificationRenderer.FormatCurrency()divided the amount by 100, assumingOrderPlacedEvent.TotalAmountwas transmitted in cents. In reality,TotalAmountis adecimalalready representing dollars — the shared contract (Shared.Contracts.Events.OrderPlacedEvent), the HTTP DTO, and theOrderEventConsumerall pass the value through without any cents conversion. The erroneous/ 100mdivision turned149.99into1.4999, which formatted as$1.50.Fix: Remove the
/ 100mdivision and format the amount directly. Updated the XML doc comment to reflect that the amount is already in dollars.Before / After
Review & Testing Checklist for Human
OrderPlacedEvent.TotalAmountsend dollars, not cents. This PR only confirmed the HTTP test endpoint and the shared contract. If the Order service (or any RabbitMQ publisher) converts to cents before publishing, this fix would be wrong and the bug is actually on the producer side. Check the Order service's event publishing code./api/notification/events/order-placedwith{"orderId": "11111111-1111-1111-1111-111111111111", "customerId": "22222222-2222-2222-2222-222222222222", "totalAmount": 149.99, "placedAt": "2026-03-17T12:00:00Z"}, then open the preview URL and confirm the total shows $149.99.0.00,0.01,999999.99— confirm formatting is correct.Notes
ToString("C2")uses the server's current culture for currency symbol/formatting. This was already the behavior before this change and is unchanged. If the production server's culture differs fromen-US, the currency symbol may not be$.FormatCurrency. Consider adding tests to prevent regressions.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/de2199abe91f476ab6c2d2be1ca7a561