fix: correct order total display in notification emails ($149.99 showing as $1.50)#20
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…il rendering Root cause: FormatCurrency() in NotificationRenderer.cs divided the amount by 100, assuming TotalAmount was in cents. However, OrderPlacedEvent.TotalAmount is a decimal representing dollars (e.g. 149.99), not cents. The division caused 49.99 to display as .50 in order confirmation emails. Fix: Remove the erroneous '/ 100m' division and use the amount directly. Also corrected the misleading comment that claimed the amount was in cents.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Order confirmation notification emails were displaying wrong totals after the microservice decomposition — a $149.99 order showed as $1.50 in the email preview.
Root cause:
FormatCurrency()inNotificationRenderer.csdivided the amount by 100, assumingOrderPlacedEvent.TotalAmountwas transmitted in cents. However, theOrderPlacedEventcontract definesTotalAmountas adecimalalready representing dollars (e.g.149.99). The erroneous/ 100mdivision turned149.99into1.4999, which then displayed as$1.50.Fix: Removed the
/ 100mdivision and corrected the misleading comment.Before (total shows ¤1.50):

After (total shows ¤149.99):

Review & Testing Checklist for Human
OrderPlacedEventsendTotalAmountin dollars, not cents — if any upstream service (e.g., Order service) actually sends cents, this fix would break that path. Check the Order service's event publishing code.{"orderId": "11111111-1111-1111-1111-111111111111", "customerId": "22222222-2222-2222-2222-222222222222", "totalAmount": 149.99, "placedAt": "2026-03-17T12:00:00Z"}tohttp://localhost:5005/api/notification/events/order-placed, and confirm the preview shows $149.99. Also test with edge cases like0.01,999999.99, and0.Notes
FormatCurrencyisprivate staticand only called withinNotificationRenderer, so the blast radius of this change is limited to notification email rendering.ToString("C2")relies on the server's current culture for the currency symbol — this is a pre-existing behavior, not introduced by this PR.FormatCurrency; consider adding one to prevent regression.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/4f9482b9dc0f4d579b44ddce90e737c0