Skip to content

fix: remove incorrect cents-to-dollars conversion in notification currency formatting #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove incorrect cents-to-dollars conversion in notification currency formatting #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Services/Notification/Notification.API/Notification.API.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
<ItemGroup>
<ProjectReference Include="..\Notification.Domain\Notification.Domain.csproj" />
<ProjectReference Include="..\Notification.Infrastructure\Notification.Infrastructure.csproj" />
<ProjectReference Include="..\..\Shared\Shared.Contracts\Shared.Contracts.csproj" />
<ProjectReference Include="..\..\Shared\Shared.Infrastructure\Shared.Infrastructure.csproj" />
<ProjectReference Include="..\..\..\Shared\Shared.Contracts\Shared.Contracts.csproj" />
<ProjectReference Include="..\..\..\Shared\Shared.Infrastructure\Shared.Infrastructure.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="10.*" />
Expand Down
8 changes: 3 additions & 5 deletions src/Services/Notification/Notification.API/Services/NotificationRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@ public class NotificationRenderer
/// </summary>
private static string FormatCurrency(decimal amount)
{
// The OrderPlacedEvent.TotalAmount is transmitted in cents (integer
// representation) to avoid floating-point precision issues across
// service boundaries. Convert back to dollars for display.
var dollars = amount / 100m;
return dollars.ToString("C2");
// The OrderPlacedEvent.TotalAmount is already in dollars (decimal).
// Format directly as currency for display.
return amount.ToString("C2");
}

public string RenderOrderConfirmation(OrderNotification notification)
Expand Down