fix: remove incorrect cents-to-dollars conversion in notification email renderer#25
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…derer The FormatCurrency method was dividing the amount by 100, assuming the OrderPlacedEvent.TotalAmount was in cents. However, the shared contract and HTTP DTO both transmit the amount in dollars (decimal). This caused a $149.99 order to display as $1.50 in the email preview. Also fixes the Shared project reference paths in Notification.API.csproj (../../Shared -> ../../../Shared) to resolve build failures.
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause: The
FormatCurrencymethod inNotificationRendererwas dividing the amount by 100 (amount / 100m), based on an incorrect assumption thatOrderPlacedEvent.TotalAmountwas transmitted in cents. In reality, the sharedOrderPlacedEventcontract and the HTTP DTO both defineTotalAmountas adecimalin dollars. This caused a $149.99 order to display as $1.50 in the email preview (149.99 / 100 = 1.4999→ rounded to$1.50).Fix:
NotificationRenderer.cs— Removed the erroneous/ 100mdivision inFormatCurrency. The amount is now formatted directly as received.Notification.API.csproj— Fixed incorrect relative paths toShared.ContractsandShared.Infrastructureproject references (../../Shared→../../../Shared), which was causing build failures (MSB9008).Before (bug) — $149.99 order shows as $1.50
After (fix) — $149.99 order correctly shows as $149.99
Review & Testing Checklist for Human
FormatCurrencychange doesn't affect any other callers — confirm no other code path sends amounts in centsTest Plan
cd src/Services/Notification/Notification.API && dotnet run --urls "http://localhost:5005"curl -X POST http://localhost:5005/api/notification/events/order-placed -H "Content-Type: application/json" -d '{"orderId": "11111111-1111-1111-1111-111111111111", "customerId": "22222222-2222-2222-2222-222222222222", "totalAmount": 149.99, "placedAt": "2026-03-17T12:00:00Z"}'PreviewUrl— the total should show $149.99Notes
Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/70ea65544da44d968663f241a21529c5