Repository navigation
tooling: the type generator names the record and says what a type cannot; capabilities.tool_args; vectors from the reference - #34
Merged
Conversation
…s what a type cannot; capabilities.tool_args; vectors from the reference Found by pinning the harness to 1.2.0: generate-contract-types.mjs read schemas/index.json as a schema and had no name for lease-record; it also dropped every keyword TypeScript cannot express without a trace, which the second review named. The generated header now lists them. capabilities on both plugin schemas gains tool_args so it stays the lease allow shape property for property. The narrowing vectors are regenerated from the harness (the tool-args-dropped vector was hand-written in 1.2.0). One fixture reason reworded off a banned marker word. Spec contract-batch-two-implement-all task 8.3, DR-183, COGDEV-268. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Jason Cruz Falzon <jason@cognitivedelivery.co.uk>
The harness's corpus hygiene test bans the marker "bearer " in any fixture,
and the valid fixture's documented `Authorization: Bearer ${TOKEN}` form hit
it. A whole-value interpolation shows the same thing without the marker; the
invalid fixtures keep their deliberately credential-shaped literals.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Jason Cruz Falzon <jason@cognitivedelivery.co.uk>
…n key The harness's corpus hygiene test bans the marker in valid fixtures; custom header names show the same interpolation form. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Jason Cruz Falzon <jason@cognitivedelivery.co.uk>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Jason Cruz Falzon <jason@cognitivedelivery.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by pinning the harness to 1.2.0 (spec
contract-batch-two-implement-alltask 8.3, COGDEV-268). Goes out as 1.2.1.generate-contract-types.mjs: reads*.schema.jsononly (it tripped overschemas/index.json);lease-recordhas a type name; every keyword a TypeScript type cannot express (allOfwithif/then,propertyNames,pattern, the bounds, …) is listed in the generated header with a count and an example site instead of being dropped silently.capabilities.tool_argson both plugin schemas: the leaseallowshape property for property, now thatallowcarriestool_args. Additive (guard against v1.2.0: 0 tightenings).conformance/narrowing-vectors.jsonregenerated from the reference implementation withtool-args-droppedas a case; 1.2.0's hand-written vector lacked thediffthe generator records and sat last.lease-record.revoked-by-issuerfixture reason reworded off the word the harness's corpus hygiene test bans.🤖 Generated with Claude Code