WIP: Add Silent Payments + BIP 375 Support #587
+2,527
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stabilize simulator debug
ec_pubkey_tweak_mul ec_pubkey_combine generator curve_order
include shim for testing ngu modules
macgyver13
force-pushed
the
silentpayments-bip375-psbt
branch
from
e065256 to
4923edd
Compare
scgbckbone
reviewed
Dec 5, 2025
shared/bech32.py
Outdated
| @@ -0,0 +1,135 @@ | |||
| # from <https://github.com/sipa/bech32/blob/master/ref/python/segwit_addr.py> | |||
Collaborator
There was a problem hiding this comment.
you shouldn't need this - just import bech32 we bundle it together with ngu from this C port https://github.com/sipa/bech32/tree/10d38fbba12da9f93c54c7fd44376152e1c06d85
Author
There was a problem hiding this comment.
Good catch! Thank you for the feedback.
Unfortunately, I could not use any existing encoding functions in ngu so I followed the scheme of adding nip19 encoding to add bip352_encode. If you have a better idea please let me know.
Collaborator
There was a problem hiding this comment.
yeah, I completely forgot we only expose segwit_{encode/decode} thru ngu.codecs - sorry for unreliable info.
Your approach, adding it to the libngu, is correct.
Update libngu Submodule to support bip352_encode
macgyver13
force-pushed
the
silentpayments-bip375-psbt
branch
from
4923edd to
c5b5977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with Sparrow Air Gapped Wallet commit a6081970 and simulator on mainnet
After putting together some python BIP 375 examples I took a look at the coldcard firmware and discovered it would be a easy lift to create a Proof of Concept to evaluate silent payments since PSBTv2 was already supported. This PR focuses on core behavior and minimal UI/UX changes.
The commits were organized to make review as easy as possible. There are some # TODO: in code where I don't have enough knowledge to make a decision at this time. Appreciate your feedback and advice on this PR.
TODOs:
screenshots
