Feature add Send_UNO_Command postMessage#6099
Merged
pedropintosilva merged 1 commit intoCollaboraOnline:masterfrom Apr 3, 2023
Merged
Feature add Send_UNO_Command postMessage#6099pedropintosilva merged 1 commit intoCollaboraOnline:masterfrom
pedropintosilva merged 1 commit intoCollaboraOnline:masterfrom
Conversation
|
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
pmzi
force-pushed
the
feature-add-send-uno-command-post-message
branch
from
f5981df to
78b36e7
Compare
Signed-off-by: Pouya Mozaffar Magham <pouya.mozafar@gmail.com> Change-Id: I465293b1d2d4bdc25b237a8a7054bf428543464b
pmzi
force-pushed
the
feature-add-send-uno-command-post-message
branch
from
78b36e7 to
271734b
Compare
Contributor
|
related to #6099 |
Contributor
|
Merging this change doesn't affect ui tests for that matter, thank you so much @pmzi ! 🥳 |
|
Thanks a lot for your contribution, and congrats on your first pull request merged! Welcome aboard! 🎉🎉🎉 If you haven't decided on your next task yet, take a look at our easy-hacks. We're looking forward to your next pull request! :) |
Contributor
|
Lets get this back-ported to 22.05 as well if we can - thanks for the feature ! useful for Cypress testing too =) |
Member
|
FWIW I updated https://sdk.collaboraonline.com/docs/postmessage_api.html |
Contributor
|
Thank you @timar ! |
Contributor
Author
|
When will be this available inside the docker image? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We needed to execute UNO commands using
postMessagefrom outside of the iframe, in order to add some custom UI and custom functionality. So, because executing UNO commands (especially with arguments like InsertBookMark) was not supported, we decided to add it as a general feature.I have updated the
framed.doc.htmlfile, I don't know if there is any file or documentation I should update for this PR. If any, please mention it and I will update it.framed.doc.htmlpreview:This is also our use case that uses
.uno:InsertBookMarkUNO command:Our code is to add a sharing feature inside Collabora using custom-added buttons (using
Insert_ButtonpostMessage). We listen to the buttons' clicks and then we want to add a custom bookmark on the text (using UNO commands). (PR: BurnaSmartLab/osjs-office-collabora#4)I have also run the code and tested it using Gitpod.
Checklist
make checkmake runand manually verified that everything looks okay