or yossef #24
Open
or yossef #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamir198
requested changes
Jan 4, 2025
Member
Tamir198
left a comment
Tamir198
left a comment
There was a problem hiding this comment.
Good work overall.
Some general notes :
When you have hardcoded strings extract them into constants file
|
|
||
| const Country = () => { | ||
| const Country = ({ name, flag, population, region, capital, onClick }) => { | ||
| return ( |
Member
There was a problem hiding this comment.
Good work on destruct the props, by doing this you are flattening your data and sending the most simple props to your componenet
| </button> | ||
| <h2>{country.name}</h2> | ||
| <img src={country.flag} alt={`Flag of ${country.name}`} /> | ||
| <p><strong>Population:</strong> {country.population.toLocaleString()}</p> |
Member
There was a problem hiding this comment.
In here you better destruct your props as well
| <p><strong>Population:</strong> {country.population.toLocaleString()}</p> | ||
| <p><strong>Region:</strong> {country.region}</p> | ||
| <p><strong>Capital:</strong> {country.capital}</p> | ||
| <p><strong>Subregion:</strong> {country.additionalInfo.subregion}</p> |
Member
There was a problem hiding this comment.
Another thing, do not use the strong tag, use css instead
| const fetchCountries = async () => { | ||
| try { | ||
| const response = await fetch("https://restcountries.com/v3.1/all"); | ||
| const data = await response.json(); |
Member
There was a problem hiding this comment.
Save the hardcoded string into constants, and the fetch function should be extracted to a service that handles api requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
done API