feat: headless Electron launch smoke test (Linux) - #733
Draft
Letark wants to merge 1 commit into
Draft
Conversation
Add a headless launch test to the packaging-smoke job that verifies the packaged AppImage actually boots without crashing. - New script: scripts/test-electron-headless-launch.mjs - Extracts x64 AppImage to temp directory - Launches under xvfb-run with --no-sandbox (CI-safe) - Monitors stdout for [Startup] log markers (30s timeout) - Waits 5s stabilization period after markers found - Cleans up extracted files - Linux-only (skips gracefully on other platforms) - Workflow changes: build.yaml + release.yaml - Added xvfb to apt-get install (alongside squashfs-tools) - New step 'Headless Electron launch test (Linux)' after smoke_run - Runs only on ubuntu-latest via xvfb-run --auto-servernum - Docs: docs/ci-cd.md updated with script description What this proves: - Electron initializes (no missing native modules, no crash on import) - Main process reaches app.whenReady() and emits startup logs - Reticulum sidecar path resolution succeeds (no missing binary crash) - Basic renderer loading (implicit via process staying alive)
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a headless launch test to the
packaging-smokejob that verifies the packaged AppImage actually boots without crashing. This fills the gap between "files exist with correct metadata" and "the app runs."What it does
xvfb-runwith--no-sandbox(CI-safe Electron flags)[Startup]log markers (30s timeout)What this proves
app.whenReady()and emits startup logsWhat changed
scripts/test-electron-headless-launch.mjs.github/workflows/build.yaml.github/workflows/release.yamldocs/ci-cd.mdTesting
xvfbpackage (added to apt-get install step)xvfb-run --auto-servernum node scripts/test-electron-headless-launch.mjsNotes