Skip to content

fix(reticulum): CodeRabbit a11y and listener-off retry toast - #748

Merged
rinchen merged 4 commits into
mainfrom
fix/rncp-coderabbit-a11y-followups
Jul 31, 2026
Merged

fix(reticulum): CodeRabbit a11y and listener-off retry toast#748
rinchen merged 4 commits into
mainfrom
fix/rncp-coderabbit-a11y-followups

Conversation

@rinchen

@rinchen rinchen commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

Test plan

  • Remote sidebar badge shows amber-800 styling and passes axe with pending offers.
  • Badge/aria show 99+ when pending offers exceed 99.
  • Chat DM offer banner Accept/Reject has no axe violations.
  • Retry of a failed transfer with listenerLikelyOff toasts the listener-off message (not peer offline).

Summary by CodeRabbit

  • Bug Fixes

    • Retry attempts now show a clear error when the receiving destination is unreachable, without opening an unnecessary dialog.
    • Remote pending-offer counts display correctly, including a capped “99+” indicator and clearer labeling.
    • Remote transfer requests now include readable instructions and destination details across compatible messaging apps.
  • Accessibility

    • Improved accessibility support for Remote offer badges and transfer banners.

Darken the Remote pending-offer badge, align 99+ aria with the visible cap, add axe coverage, and toast listener-off distinctly when retry skips the enable modal.
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rinchen, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: d6959e39-43b6-488c-8f65-6446919ef178

📥 Commits

Reviewing files that changed from the base of the PR and between d9ba258 and 9a2c05e.

⛔ Files ignored due to path filters (16)
  • src/renderer/locales/cs/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/de/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/en/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/es/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/fr/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/id/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/it/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/ja/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/ko/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/nl/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/pl/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/pt-BR/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/ru/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/tr/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/uk/translation.json is excluded by !src/renderer/locales/**
  • src/renderer/locales/zh/translation.json is excluded by !src/renderer/locales/**
📒 Files selected for processing (2)
  • src/renderer/components/remote/RncpEnableRequestModal.test.tsx
  • src/renderer/components/remote/RncpEnableRequestModal.tsx
📝 Walkthrough

Walkthrough

The changes update RNCP message formatting, Remote transfer retry feedback, and Remote pending-offer badge styling and accessibility tests.

Changes

Remote transfer updates

Layer / File(s) Summary
RNCP message formatting
src/shared/rncpRequestEnable.ts, src/shared/rncpRequestEnable.test.ts, src/renderer/lib/sendRncpRequestEnable.test.ts
RNCP messages now include readable instructions, plain destination hashes, and mesh-client sentinels with exact formatting tests.
Remote retry feedback
src/renderer/components/remote/RemoteTransferSection.tsx, src/renderer/components/remote/RemoteTransferSection.test.tsx
Retry operations show an error toast when the peer receive destination is unreachable and no enable-request modal is requested.
Remote badge accessibility
src/renderer/components/Sidebar.tsx, src/renderer/components/Sidebar.test.tsx, src/renderer/components/remote/ChatDmRncpOfferBanner.test.tsx
The pending-offer badge uses capped aria labeling, a darker amber background, and accessibility assertions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the pull request's main changes: accessibility updates and a listener-off retry toast.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rncp-coderabbit-a11y-followups

Comment @coderabbitai help to get the list of available commands.

rinchen added 3 commits July 31, 2026 09:26
Drop mesh-client UI paths and the request-enable sentinel from outbound LXMF so Sideband/Nomad peers get a clear human ask for their rncp receive hash.
Restore the trailing mesh-client sentinel so receivers still open the enable/share modal, while leaving the human LXMF line app-agnostic.
…miss

Auto-dismiss repeat enable-requests when already listening, broaden identity resolve before Always allow, and soften the toast when Ask enables without an identity hash yet.
@rinchen
rinchen merged commit c94cbaa into main Jul 31, 2026
12 checks passed
@rinchen
rinchen deleted the fix/rncp-coderabbit-a11y-followups branch July 31, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant