Skip to content

test(meshcore): fix renderer-ui setup-abort reconnect contract #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rinchen merged 2 commits into from
Aug 8, 2026
Merged

test(meshcore): fix renderer-ui setup-abort reconnect contract #822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
624f169
test(meshcore): make setup-abort reconnect contract resilient to cleanup
rinchen Aug 8, 2026
4424a06
test(meshcore): assert setup-abort cleans up transport before deferring
rinchen Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/renderer/runtime/useMeshcoreRuntime.reconnect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,9 +521,20 @@ describe('useMeshcoreRuntime manual disconnect must not auto-reconnect', () => {
// and left status=reconnecting with no further attempts (n7eal / #792 MeshCore TCP).
const abortIdx = reconnectBody.indexOf('isMeshcoreSetupAbortError(err)');
expect(abortIdx).toBeGreaterThan(-1);
const abortBlock = reconnectBody.slice(abortIdx, abortIdx + 900);
// Delimit the abort branch at the non-abort retry path rather than a fixed
// char window, so adding late-transport cleanup before the defer cannot push
// `return 'defer'` out of range.
const retryIdx = reconnectBody.indexOf("return 'retry'", abortIdx);
expect(retryIdx).toBeGreaterThan(abortIdx);
const abortBlock = reconnectBody.slice(abortIdx, retryIdx);
expect(abortBlock).toContain('meshcoreDeferredReconnectRef.current = true');
expect(abortBlock).toContain("return 'defer'");
// Setup abort must clean up any transport this doomed attempt opened *before* deferring,
// otherwise a late-opened driver leaks while the deferred restart brings up a fresh one.
const cleanupIdx = abortBlock.indexOf('lateTransport.cleanup(openedDriverIdentityId)');
const deferIdx = abortBlock.indexOf("return 'defer'");
expect(cleanupIdx).toBeGreaterThan(-1);
expect(deferIdx).toBeGreaterThan(-1);
expect(cleanupIdx).toBeLessThan(deferIdx);
expect(abortBlock).not.toMatch(/meshcoreIsReconnectingRef\.current = false/);
});

Expand Down