Repository navigation
Remove redundant wall velocity resets from simMD - #21
Closed
ColtonKawamura with Copilot wants to merge 1 commit into
Closed
ColtonKawamura with Copilot wants to merge 1 commit into
ColtonKawamura with Copilot wants to merge 1 commit into
Conversation
ColtonKawamura
added this pull request to stack #22
September 30, 2026 09:41
Copilot
AI
changed the title
[WIP] Remove redundant velocity reset block in Verlet loop
Remove redundant wall velocity resets from simMD
Sep 30, 2026
ColtonKawamura
marked this pull request as ready for review
September 30, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wall velocities remain zero because they start at zero and wall forces are zeroed each step. The additional resets in the Verlet loop are redundant.
vx/vy/vzreset block; leave force zeroing and the remaining wall handling unchanged.Status: These changes have not been applied. The available checkout is on a different branch from PR #20.