Skip to content

Add logical drive capacity to metrics collection#154

Merged
ibrahimkk-moideen merged 4 commits into
mainfrom
add-logical-drive-capacity
Oct 29, 2025
Merged

Add logical drive capacity to metrics collection#154
ibrahimkk-moideen merged 4 commits into
mainfrom
add-logical-drive-capacity

Conversation

@ibrahimkk-moideen
Copy link
Copy Markdown
Collaborator

Code test:

=== RUN   Test_Exporter_Metrics_Handling
=== RUN   Test_Exporter_Metrics_Handling/Good_Logical_Drive
--- PASS: Test_Exporter_Metrics_Handling (0.00s)
    --- PASS: Test_Exporter_Metrics_Handling/Good_Logical_Drive (0.00s)
PASS
ok  	github.com/comcast/fishymetrics/exporter	0.265s


Test result:

# HELP redfish_logical_drive_status Current Logical Drive Raid 1 = OK, 0 = BAD, -1 = DISABLED
# TYPE redfish_logical_drive_status gauge
redfish_logical_drive_status{capacityMiB="285568",chassisModel="dl365",chassisSerialNumber="xxxxxxx",logicaldrivename="",name="MR Volume",raid="RAID1",volumeuniqueidentifier="600062B2152120802C3301EEB844E987"} 1

@ibrahimkk-moideen ibrahimkk-moideen linked an issue Oct 27, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@derrick-dacosta derrick-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahimkk-moideen ibrahimkk-moideen merged commit 6962ce2 into main Oct 29, 2025
4 checks passed
@ibrahimkk-moideen ibrahimkk-moideen deleted the add-logical-drive-capacity branch October 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include capacity of logical drives in metrics collection

2 participants