Allow consuming existing secret#169
Open
agmimidi wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR uses a new boolean key named existingSecret in the values file to toggle the creation of the secret holding the BMC, vault and elastic credentials. This is important for setups were deployments are controlled via GitOps were storing confidential keys in plain text is considered a security risk.
The default value has been set to false to ensure backwards compatibility, for the same reason the secret name is still expected to be the same as before. Setting the value to true will result in Helm not templating the secret, the expectation being the user has created before hand.