Fix GitHub Pages publishing references#14
Conversation
There was a problem hiding this comment.
Pull request overview
Updates documentation and workflow metadata so GitHub Pages publishing and installation instructions correctly reference the Comfy-Org wheel index, and aligns the standalone index update workflow permissions with the release pipeline.
Changes:
- Update README build instructions and document the live PEP 503 index URLs and gh-pages publishing flow.
- Update release notes template in
build.ymlto point installs athttps://comfy-org.github.io/wheels. - Add
pages: writepermission to the standaloneupdate-index.ymlworkflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates workflow invocation repo and documents the Pages index URLs + deployment flow. |
| .github/workflows/update-index.yml | Adds Pages permission to the standalone index deployment workflow. |
| .github/workflows/build.yml | Updates release install notes to reference the Comfy-Org GitHub Pages wheel index URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| environment: deploy-index | ||
| permissions: | ||
| contents: write | ||
| pages: write |
There was a problem hiding this comment.
pages: write permission appears unnecessary for this workflow because deployment is done via peaceiris/actions-gh-pages, which pushes to the gh-pages branch using contents: write. Keeping pages: write expands GITHUB_TOKEN scope beyond what’s needed; consider removing it (or only adding it if migrating to the official Pages deployment actions that require pages/id-token permissions).
| pages: write |
0e48e7a to
1b127f6
Compare
Summary
Verification