Skip to content

Fix GitHub Pages publishing references#14

Merged
pollockjj merged 1 commit into
Comfy-Org:mainfrom
pollockjj:fix/gh-pages-publishing-docs
Apr 22, 2026
Merged

Fix GitHub Pages publishing references#14
pollockjj merged 1 commit into
Comfy-Org:mainfrom
pollockjj:fix/gh-pages-publishing-docs

Conversation

@pollockjj
Copy link
Copy Markdown
Collaborator

Summary

  • point release install notes at the Comfy-Org GitHub Pages wheel index
  • document the live PEP 503 index URLs and the gh-pages deployment flow
  • grant the standalone update-index workflow the same Pages permission used by build.yml

Verification

Copilot AI review requested due to automatic review settings April 22, 2026 01:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates documentation and workflow metadata so GitHub Pages publishing and installation instructions correctly reference the Comfy-Org wheel index, and aligns the standalone index update workflow permissions with the release pipeline.

Changes:

  • Update README build instructions and document the live PEP 503 index URLs and gh-pages publishing flow.
  • Update release notes template in build.yml to point installs at https://comfy-org.github.io/wheels.
  • Add pages: write permission to the standalone update-index.yml workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
README.md Updates workflow invocation repo and documents the Pages index URLs + deployment flow.
.github/workflows/update-index.yml Adds Pages permission to the standalone index deployment workflow.
.github/workflows/build.yml Updates release install notes to reference the Comfy-Org GitHub Pages wheel index URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

environment: deploy-index
permissions:
contents: write
pages: write
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages: write permission appears unnecessary for this workflow because deployment is done via peaceiris/actions-gh-pages, which pushes to the gh-pages branch using contents: write. Keeping pages: write expands GITHUB_TOKEN scope beyond what’s needed; consider removing it (or only adding it if migrating to the official Pages deployment actions that require pages/id-token permissions).

Suggested change
pages: write

Copilot uses AI. Check for mistakes.
@pollockjj pollockjj force-pushed the fix/gh-pages-publishing-docs branch from 0e48e7a to 1b127f6 Compare April 22, 2026 01:35
@pollockjj pollockjj merged commit 5fa6c86 into Comfy-Org:main Apr 22, 2026
5 checks passed
@pollockjj pollockjj deleted the fix/gh-pages-publishing-docs branch April 22, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants