Skip to content

test: cover core settlement reentrancy guard#520

Closed
dangelo352 wants to merge 1 commit into
Commitlabs-Org:masterfrom
dangelo352:security/core-settle-reentrancy-487
Closed

test: cover core settlement reentrancy guard#520
dangelo352 wants to merge 1 commit into
Commitlabs-Org:masterfrom
dangelo352:security/core-settle-reentrancy-487

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • wire the existing commitment_core security review tests into the test harness
  • update two stale security review assertions to the current is_authorized API
  • add regression coverage that settle and early_exit reject with an active reentrancy guard and clear the guard on validation rejections
  • document the settlement-path reentrancy invariant

Closes #487.

Validation

  • CARGO_TARGET_DIR=/tmp/commitlabs-reentrancy-target cargo test -p commitment_core security_review_tests -- --nocapture
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reentrancy guard around the cross-contract calls in commitment_core::settle

2 participants