test: cover marketplace token reentrancy#526
Closed
dangelo352 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buy_nft,accept_offer, competingplace_bidwith previous-bid refund, andend_auctionsettlementSECURITY_CHECKLIST.mdwith the tested scenarios and note that current offer cancellation has no token refund transferCloses #479.
Tests
CARGO_TARGET_DIR=/tmp/commitlabs-market-reentry-target cargo test -p commitment-marketplace reentrant_payment_token -- --nocaptureCARGO_TARGET_DIR=/tmp/commitlabs-market-reentry-target cargo test -p commitment-marketplace reentrancy -- --nocapturegit diff --checkNote: the generated Soroban client exposes the nested guard rejection inside the mock token as an outer contract-call error; existing explicit guard tests in the same filter continue to assert
MarketplaceError::ReentrancyDetected(#20) directly.