feat: wire early exit modal to live preview#619
Closed
xx7412421-cloud wants to merge 10 commits into
Closed
Conversation
|
@xx7412421-cloud is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
the early-exit live-preview wiring looks like solid work, but the same process applies — #579 isn't assigned to you. please get assigned first, then reopen; i'm closing as invalid until then. ping us on https://discord.gg/WV7tdYkJk if you want help claiming it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #579
Summary
Validation
npm exec -- vitest run tests/components/CommitmentEarlyExitModal.test.tsx tests/components/earlyExitPreview.test.tsnpm exec -- eslint src/app/commitments/page.tsx src/components/CommitmentEarlyExitModal/CommitmentEarlyExitModal.tsx src/components/CommitmentEarlyExitModal/earlyExitPreview.ts tests/components/CommitmentEarlyExitModal.test.tsx tests/components/earlyExitPreview.test.tsnpm exec -- prettier --check src/components/CommitmentEarlyExitModal/earlyExitPreview.ts tests/components/earlyExitPreview.test.tsgit diff --check origin/master..HEADFull
npm run test -- --runwas also attempted, but the repository baseline still has unrelated failures outside this change, including duplicate declarations in backend modules, existing invalid JSX inCommitmentDetailsModal.tsx, missing@testing-library/user-event,jest is not definedin an existing Vitest file, and several tests missing DOM environment setup.