Skip to content

Add health metrics tab coverage#664

Open
Mayreck wants to merge 1 commit into
Commitlabs-Org:masterfrom
Mayreck:codex/health-metrics-tabs-coverage
Open

Add health metrics tab coverage#664
Mayreck wants to merge 1 commit into
Commitlabs-Org:masterfrom
Mayreck:codex/health-metrics-tabs-coverage

Conversation

@Mayreck

@Mayreck Mayreck commented Jun 23, 2026

Copy link
Copy Markdown

Summary

  • Add accessible tab semantics to the Health Metrics chart switcher
  • Add keyboard navigation with ArrowLeft, ArrowRight, Home, and End
  • Add Vitest/RTL coverage that mocks child charts and verifies data routing for all four tabs
  • Document the coverage in docs/testing/HEALTH_METRICS_TABS_TESTS.md

Validation

  • npx vitest run src/components/dashboard/CommitmentHealthMetrics.test.tsx
  • npx eslint src/components/dashboard/CommitmentHealthMetrics.tsx src/components/dashboard/CommitmentHealthMetrics.test.tsx

Baseline notes

  • Existing repo-wide npm run lint and npx tsc --noEmit remain blocked by unrelated baseline syntax/lint issues noted in PR Add RecentAttestationsPanel test coverage #663, including src/app/api/commitments/[id]/settle/route.ts and src/components/modals/CommitmentDetailsModal.tsx.

Closes #646.

@vercel

vercel Bot commented Jun 23, 2026

Copy link
Copy Markdown

@Mayreck is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

@GBOYEE

GBOYEE commented Jun 24, 2026

Copy link
Copy Markdown

I'd like to work on this.

Approach:

  • I'll write the test cases and ensure they pass with full coverage
  • Verify with existing tests + add new ones if needed

Estimated effort: ~1-2 hours. PR incoming shortly.

1 similar comment
@GBOYEE

GBOYEE commented Jun 24, 2026

Copy link
Copy Markdown

I'd like to work on this.

Approach:

  • I'll write the test cases and ensure they pass with full coverage
  • Verify with existing tests + add new ones if needed

Estimated effort: ~1-2 hours. PR incoming shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RTL tests for CommitmentHealthMetrics tab switching across all four chart tabs

2 participants