Skip to content

Improve error messages in ErrorResponseExceptionMapper #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ruhan1 wants to merge 1 commit into from
Closed

Improve error messages in ErrorResponseExceptionMapper #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/main/java/org/commonjava/service/promote/client/ErrorResponseExceptionMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,34 @@ public RuntimeException toThrowable(Response response)
{
try (InputStream is = (InputStream) entity)
{
throw new WebApplicationException(IOUtils.toString(is, Charset.defaultCharset()));
String errorBody = IOUtils.toString(is, Charset.defaultCharset());
throw new WebApplicationException(
String.format("HTTP 500 error from service: %s", errorBody),
response.getStatus()
);
}
catch (IOException e)
{
throw new WebApplicationException("Unknown error, " + e.getMessage());
throw new WebApplicationException(
String.format("HTTP 500 error from service (failed to read response body: %s). Headers: %s",
e.getMessage(), response.getHeaders()),
response.getStatus()
);
}
}
else
{
throw new WebApplicationException(entity.toString());
throw new WebApplicationException(
String.format("HTTP 500 error from service: %s", entity.toString()),
response.getStatus()
);
}
}
throw new WebApplicationException("Unknown error");
throw new WebApplicationException(
String.format("HTTP 500 error from service with no response body. Headers: %s, Status Info: %s",
response.getHeaders(), response.getStatusInfo()),
response.getStatus()
);
}
return null;
}
Expand Down
Loading