Skip to content

[T3352] FIX: guard letter submit against double-click race - #356

Merged
Danielgergely merged 1 commit into
14.0from
T3352-letter-progress-race
Aug 4, 2026
Merged

[T3352] FIX: guard letter submit against double-click race#356
Danielgergely merged 1 commit into
14.0from
T3352-letter-progress-race

Conversation

@Danielgergely

Copy link
Copy Markdown
Member
  • FIX: Guard _onSubmitLetter to prevent a double click + error

- FIX: Guard _onSubmitLetter to prevent a double click + error
@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex ran the guard harness for the two-generator submission guard and it completed successfully.
  • The harness loaded and evaluated the actual my2_new_letter.js handler for both revisions, ensuring the code path is shared and not duplicated.
  • The reviewer observed that before the change immediate Send and Preview submissions produced two generators, while after the change the same interaction produced exactly one generator and the initiating Send button was disabled during collection, with both collection and create-generator paths releasing the guard and re-enabling the button on completion or failure.
  • Implementation details were validated: the guard blocks re-entry at lines 62–66 and the cleanup releases the guard at lines 161–162, preserving retry behavior.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "[T3352] FIX: guard letter submit against..." | Re-trigger Greptile

@Danielgergely
Danielgergely merged commit 4876398 into 14.0 Aug 4, 2026
2 checks passed
@Danielgergely
Danielgergely deleted the T3352-letter-progress-race branch August 4, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant