Conversation
- FIX: show the beginning-of-sponsorship photo (was filtered out by import date); date photos by their real date, kept below the start marker - FIX: infinite-scroll offset so entries between the first page and the next batch are no longer skipped (dropped whole years of letters) - REFACTOR: derive the total via COUNT(*) OVER (), dropping the duplicate count query Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
defensive programming
[T3228] FIX: correct MyCompassion timeline photos and missing entries
- FIX: making sure the action url is re-computed for every participant every time their profile loads (with the t- tag)
…ction [T3325] FIX: event donation form posting to wrong participant
…-less) language - quickfix for v14, should already be handled in v18 - FEAT: added language switcher to muskathlon event
…ault-lang [T3344] FIX: language switcher couldn't return to the default (prefixless) language
- Drive the cron from device tokens instead of scanning 10'000+ children;
…rformance [T3350] FIX: birthday push cron stalled all scheduled actions
The portal computed can_i_write_letter/is_writer straight off recurring.contract.can_write_letter, which is False whenever the project has hold_s2b_letters set, hiding the "Write a letter" option entirely while the FCP is suspended. Pass allow_during_suspension in context when computing these, mirroring what mobile_app_connector already does for the app hub. The existing sbc_compassion correspondence.create_commkit()/hold_letters_action()/ reactivate_letters() machinery already holds the letter as an "Exception" and auto-resubmits it once the FCP reactivates - it was just never reached because the portal blocked letter creation before it could run.
- FIX: Guard _onSubmitLetter to prevent a double click + error
[T3352] FIX: guard letter submit against double-click race
Confidence Score: 4/5
 T-Rex LogsWhat T-Rex did
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| .search( | ||
| [ | ||
| ("child_id", "=", child_id), | ||
| ("partner_id", "in", partner_ids), |
There was a problem hiding this comment.
The portal authorization path permits a user linked as recurring.contract.correspondent_id, but this sponsorship lookup only searches partner_id. When the payer and correspondent differ, an authorized correspondent receives no sponsorship start or beginning picture ID; the subsequent picture query is given null values and excludes the child's pictures from the timeline. Search both partner_id and correspondent_id so the timeline lookup matches the authorization model.
Artifacts
Controller source showing payer-only sponsorship lookup
- Captured the affected controller lookup and its timeline call chain, showing that only `partner_id` is used; this establishes the precondition for the failure.
Focused correspondent-only timeline reproduction harness
- The uploaded executable harness imports the actual controller and creates a distinct payer and correspondent fixture; it exercises the claimed failure path.
Executed correspondent-only timeline reproduction
- Running the focused harness shows the correspondent authorized as partner 200, the payer-only lookup domain, a missing sponsorship start, NULL picture parameters, and an empty timeline; the candidate is reproduced.
Model authorization source for a correspondent portal user
- Captured the model query that recognizes either payer or correspondent as the user's sponsorship; it confirms the reproduced fixture is an allowed portal-access case.
Controller Python syntax validation
- Compiled the affected controller successfully after the focused execution setup; the inspected module is syntactically valid.
| sponsorship_start, | ||
| beginning_picture_id, |
There was a problem hiding this comment.
_get_timeline_data now requires sponsorship_start and beginning_picture_id, but TestChildTimeline._timeline still invokes it with only the prior four arguments. The four timeline tests fail immediately with a missing-positional-arguments TypeError, before exercising their intended timeline behavior. Update the helper to pass the new values or call _get_timeline_records, which supplies them.
Artifacts
Review-authored legacy timeline helper reproduction source
- A Python script parses the checked-out controller and focused test helper, then executes the same four-argument call; it is the source used to reproduce the failure.
Legacy timeline helper call fails with missing arguments
- Executed `python3 trex-artifacts/pr359-timeline-helper-01-before.py` in `/home/user/repo`; it reports the four affected tests and the observed missing-arguments TypeError, confirming the bug.
Review-authored complete-arity control source
- A Python control script invokes the same checked-out method with all seven positional arguments to distinguish argument binding from the unavailable Odoo runtime.
Complete timeline helper call passes argument binding
- Executed `python3 trex-artifacts/pr359-timeline-helper-02-after.py` in `/home/user/repo`; it passes argument binding and stops only at the isolated script's absent Odoo request global, confirming the prior error is arity-specific.
3 participants
No description provided.