Security: Command Injection via shell=True in with_server.py#67
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
The script uses `shell=True` in subprocess.Popen which allows shell injection attacks. User-controlled server commands could execute arbitrary shell commands. Affected files: with_server.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The script uses
shell=Truein subprocess.Popen which allows shell injection attacks. User-controlled server commands could execute arbitrary shell commands.Severity:
criticalFile:
webapp-testing/scripts/with_server.pySolution
Replace shell=True with shell=False and pass command as a list of arguments instead of a string. Use shlex.split() if shell is required, or better yet, avoid shell=True entirely.
Changes
webapp-testing/scripts/with_server.py(modified)Testing