Security: Path Traversal in package_skill.py#68
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
The script creates a zip file from a skill folder using rglob and relative_to. If a malicious symlink exists outside the skill folder, it could be followed, allowing path traversal attacks (zip slip). Affected files: package_skill.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The script creates a zip file from a skill folder using rglob and relative_to. If a malicious symlink exists outside the skill folder, it could be followed, allowing path traversal attacks (zip slip).
Severity:
highFile:
skill-creator/scripts/package_skill.pySolution
Add validation to ensure all extracted paths are within the target directory. Use os.path.realpath() to resolve symlinks and verify the resolved path is within the skill_path.parent directory.
Changes
skill-creator/scripts/package_skill.py(modified)Testing