Repository navigation
feat(contribution): a page may show a count in its menu entry (badge) - #1205
Merged
Merged
Conversation
… {collection, label})
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
October 5, 2026 17:21
rubenvdlinde
added a commit
that referenced
this pull request
Oct 5, 2026
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ❌ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-05 17:36 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
OpenSpec change
page-badge-key(new). Asked by lane L1 for the resident menu's counts (#1203, gap G-05 of the school portals).A contributed page may declare
badge: { collection, label? }.PageMenuKeysnow keeps it whencollectionis one of the same contribution's collections, withlabelas text of at most 80 characters (the site fills in{count}). Anything else is dropped, so a badge can never count another app's rows. Today the server dropsbadgewhole, so the menu in #1203 shows no counts.Independent of other PRs. #1203 reads the key.
Verified
PageMenuKeysTest::testABadgeNamesACollectionOfTheContributionthrough the realPortalManifestNormaliser: kept with a label, label too long dropped while the count stays, and four wrong shapes dropped.tests/Unit/Contributiongreen.npm run lint0 errors,check:specs0,check:l10n-js0,openspec validate page-badge-key --strict.composer check:strictonce: lint, phpcs, phpmd, psalm and phpstan clean; PHPUnit shows the same 46 inherited errors as development, by name.Not in this PR
Declaring
badgeon a portalPage record (register schema); a provider app declares it in its contribution.🤖 Generated with Claude Code