Repository navigation
feat(site): the Zuiddrecht example resident: Sanne de Vries, her cases and a sign-in without a broker - #1227
Merged
Conversation
…mands, declaration)
…s and a sign-in without a broker
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 6, 2026 05:52
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-06 05:56 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Zuiddrecht example site (#1206, #1208) had nobody to sign in as, so the area behind "Mijn Zuiddrecht" was never seen. This adds the example resident of the design, Sanne de Vries, with her cases, and a way to sign in as her on a demo or test instance without a DigiD broker and without the test sign-in.
lib/Settings/sites/residents/zuiddrecht.json: the resident (Nextcloud account idsanne.devries, audiencecitizen), the way in (modenextcloudwith the card "Voorbeeldinwoner"), and ten dossiq objects: five cases on dossiq's shipped case types (a Woo request in treatment with the design's five steps, a building permit waiting for a drawing, a report about a loose paving stone, two finished cases), one open question and four messages. Dates are counted from the day of the install; a case type is found by its identifier, a status by its name, and a message quotes the number the register gave its case. Every stored key was held against dossiq's own register file (0 unknown keys, 0 enum or required misses) and read back live.OC_PASSwith--password-from-env), the portal account, adds the sign-in mode to the portal (its card only when the portal has none), writes the objects in order, reads everything back and exits 2 when anything is dropped, missing or not kept. It never takes over an account it did not make (--userpicks another id), and a second run writes nothing.nextcloudsign-in mode, which already existed: a session is minted only for a Nextcloud account with an active portal account under the same id (checked live: admin through the same link gets 403no_portal_account). The test sign-in stays closed (404 checked live); the docs now say what it is, thatdebugmode opens it, and why it stays off.Docs:
docs/Installation/example-site-zuiddrecht.mdgained "The example resident", "Who can sign in this way", "Why not the test sign-in" and "Remove the resident". OpenSpec changeexample-resident-zuiddrecht.What the resident sees (live on a test instance, dossiq 0.4.43)
Sign-in page with the third card; the overview with "Welkom, Sanne", the question "Stuur de bouwtekening van uw dakkapel", three case cards with step bars, the newest messages; "Mijn zaken" with Lopend (3) and Afgerond (2); the case page with the five Woo steps, the detail card and the message button; Berichten with two unread. Screenshots in the coordinator's hand-back (
~/memcap-work/zuiddrecht/mijn/shots/pr1-*.png).Verified
composer check:strict(COMPOSER_PROCESS_TIMEOUT=0, own TMPDIR): lint, phpcs, psalm, phpstan green; phpmd green on this diff after the refactor commit (the earlier run named 7 complexity findings in the new files, all split); PHPUnit exit 1 with 46 errors, all inherited: the same 46 tests (PageHistoryTest, RenameDutchColumnsTest, NoticeWriteGuardListenerTest and others) fail identically on clean development, list identical to the previous lane's development baseline (diffempty), and none of their files is in this diff.npm run lintexit 0 (0 errors, 108 inherited warnings),npm run formatexit 0,node --test tests/example-resident.spec.mjs5/5, everycheck:specsmember green except two inherited bundle-size checks (check:traffic-client,check:site-edit-mode) that measure a development build on the tree they ran in. There is notest:l10nscript in this repo.HYDRA_GATE_BASE_REF=origin/development): all 86 applicable gates passed and ran.Not in this PR
Documents on a case (need a file on the case object plus an informatieobject and its join), the design's exact case numbers (the register numbers cases), a parkeervergunning case (dossiq ships none; the waiting case is an omgevingsvergunning). The case page shows "Wat er is gebeurd" and "Documenten" twice (dossiq's page declares
timelineanddocumentsblocks and thecitizenCasescreen repeats them) and one untranslated line ("This case is not open for changes from the portal"): both are inherited and listed for the coordinator.🤖 Generated with Claude Code