Skip to content

feat(accounts): Nog niet ingelogd quick filter, five pills as the board - #1533

Merged
rubenvdlinde merged 2 commits into
developmentfrom
feat/accounts-never-signed-in-filter
Oct 12, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
feat/accounts-never-signed-in-filter

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

PtAccounts quick filters as the board's five pills, now that 2.81 counts empty-field filters: Alles, Actief, Wacht op goedkeuring, Nog niet ingelogd, Ingetrokken. "Nog niet ingelogd" is {"empty": "lastLoginAt"} (reads as lastLoginAt_isnull=true). Geschorst is dropped from the strip (the board has no such pill and no account is suspended here); quickFilterMaxVisible: 5.

Verified

  • Live count on :8080: the pill shows 42, and the OpenRegister query lastLoginAt_isnull=true returns 42 (screenshot ~/memcap-work/screens/round6/PT/diffs/h5b/PtAccounts-live.png).
  • The Filter toolbar button is present (it came with 2.81).
  • Pixel PtAccounts: 11.93% (8.27 / 6.27 / 23.74 / 10.19) on this branch; the earlier 11.67% (avatar branch) had a sixth pill that wrapped the toolbar. Row heights (data) dominate what is left.
  • node --test tests/*.spec.mjs: 1517 tests, 1516 pass, 1 inherited (site-edit-mode). PHPUnit --no-coverage exit 0 (3810). manifest-v2, registry, validate-manifest exit 0. npm run build exit 0.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/portaliq @ edb728c

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
check-manifest ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
check-reuse ✅
composer ✅ ✅ 108/108
npm ✅ ✅ 984/984
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ✅ 3809/3809 · 1 skipped
Newman ✅ 1/1
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-12 16:43 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 66589a4 into development Oct 12, 2026
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant