Repository navigation
feat(site): the full product list of a theme has its own page, expired products last - #1534
Merged
Merged
Conversation
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 12, 2026 16:45
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3809/3809 · 1 skipped | ||||
| Newman | ✅ 1/1 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-12 16:50 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a resident sees now
/mijn/thema/{slug}/producten.Change:
life-domain-theme-pages, task T05b (REQ-LDT-004, scenario "An expired permit"). Board: ThemaOverzicht.How
src/shared/portalNav.js:themeProductsRoute(),isThemeProductsRoute(), andnavEntryForRoute()resolves the deeper route to the theme's entry. A theme the server did not announce resolves to nothing.AccountArea.vuehands a page the route on screen (currentRoute), only to a page that declares the prop.ThemePage.vuereads the route. The toggle and its "Minder tonen" string are gone; "Terug naar {thema}" is new, in Dutch and English.For the reviewer
Tests
tests/life-domain-themes.spec.mjs, 13 pass. Four are new: the route and its resolution, three products plus the link on the theme page, the full list with the expired permit last, and the empty list.Checks, by exit code
npm run lint,stylelint,formatnpm run check:specs,check:l10n-js,check:reusedevelopment; #1532 fixes it.No PHP changed, so
check:strictwas not run. No production build was run locally.Still open on the change