Repository navigation
feat(intake): portaliq tells OpenRegister which published forms write into a schema about to change - #1538
Merged
Conversation
… into a schema about to change
…re optional sibling classes
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 12, 2026 18:18
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3819/3819 · 1 skipped | ||||
| Newman | ✅ 1/1 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-12 18:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dossiq's decision 179 lane needs this. Before OpenRegister saves a schema it asks every app which published forms write into it (
FormDestinationDependentsEvent, openregister #4563). Portaliq did not answer. A schema change could break a published portal form and nobody was told.I checked on openregister
development(c021ddb0) that the event is really dispatched:lib/Service/Form/FormDependentsCheck.php:96, called fromSchemasController.What happens now
public.draft. It keeps everything else.How
Listener\FormDestinationDependentsListener(new)FormDestinationDependentsListenerTest, 6 testsAppInfo\FormDependentsRegistrar(new), called fromApplication::register()FormDependentsRegistrarTest, 3 testsPortalFormBindingResolver::allPublishedBindings()PortalFormBindingResolverTest::testEveryPortalsPublishedBindingsAreListedAndNoDraftFormDependentsCheck. A schema that drops a property the form writes names the binding withproperty-unknown; applying the save writesstatus: draft.register()and finds the listener on the event. I removed the call once as a control and the test failed.psalm.xmllists the two OpenRegister classes as optional sibling classes, like the other OpenRegister events.submit-creates-the-case-directlygains the sentence and a scenario. Task 6b.1 is ticked, 6b.2 is the live check.For the reviewer
@self.owner). A binding without one gets no notification.PortalObjectWriter, scoped to the binding's own portal. The diff adds no_rbacline.formDestinationBreakfor appportaliq, defaultunpublish. Portaliq sets nothing.Checks, by exit code
composer lint,phpcs,phpmd,psalm,phpstanvendor/bin/phpunit --no-coverage(full suite, against openregisterdevelopmentlib)development; #1532 fixes it.No frontend file changed, so the npm checks were not run.
Still owed
Live check (task 6b.2): on an instance with dossiq, publish a binding into a case schema, remove a property its form writes, and save the schema. The save lists the binding under
affected, the binding readsdraft, and its owner gets the notification.