Repository navigation
fix: clear development's reds (boot test on Nextcloud 32 to 34, gate 102 placeholders) - #1570
Merged
Merged
Conversation
…n Nextcloud 32 to 34) The boot test mocked getAppContainer() with a bare ContainerInterface. Nextcloud 32 to 34 declare that method as returning IAppContainer, so six PHPUnit cells failed on development 31cf029; only stable35 passed. IAppContainer extends ContainerInterface, so one stand-in fits every version. Control: a mock of an IAppContainer-typed method refuses the bare stand-in and accepts IAppContainer. Gate 102: the language and web-address chips fields from #1536 carry placeholders 'nl' and 'https://www.example.nl' without an nl.json key.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 14, 2026 19:07
Contributor
Quality Report — ConductionNL/portaliq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-reuse | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 984/984 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 3883/3883 · 1 skipped | ||||
| Newman | ✅ 1/1 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-14 19:17 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development 31cf029 (push run 38611485799, 46 checks: 32 pass, 8 fail, 6 skipped) is red on two portaliq causes. This PR clears both.
PHPUnit, 6 of 8 cells (PHP 8.3 and 8.4 on stable32, 33, 34).
HostRootRedirectBootTestmockedgetAppContainer()with a bareContainerInterface. Nextcloud 32 to 34 declare that method as returningIAppContainer; 35 declaresContainerInterface. So only the two stable35 cells passed. The stand-in is now anIAppContainermock, which extendsContainerInterfaceand fits both. Control: a method typedIAppContainerrefuses the bare mock (IncompatibleReturnValueException, the CI error) and accepts theIAppContainerone.Hydra Gates, gate 102. The language and web-address chips fields from #1536 carry the placeholders
nlandhttps://www.example.nlwithout an nl.json key. Both keys are added to nl.json and en.json,npm run l10n:buildrun.Quality Report follows Hydra Gates and clears with it.
Verified locally (exit codes):
check_manifest_l10n_coverage.py): 0, 483 stringscheck:l10n-js,check:schema-l10n,check:manifest,check:json-strict: 0phpunit --no-coverage tests/Unit/AppInfo/HostRootRedirectBootTest.php: 6 tests OK (local ocp is 35, so the old signature was checked by the control above, not by this run)Inherited: phpcs reports named-argument findings across this test file, the same on development; tests/ is outside
phpcs.xml's scope.