Repository navigation
chore(sync): carry beta back into development - #1095
Merged
rubenvdlinde merged 4 commits intoOct 5, 2026
Merged
Conversation
Nextcloud core's CSS reset sets dialog { display: block }, which beats the browser's own dialog:not([open]) { display: none }. Both dialogs therefore rendered loose on the admin page, and opening the base-token confirm pushed the settings layout out of view.
…ve them padding
The same Nextcloud core reset that forces dialog { display: block } also zeroes margin and padding on dialog. That removed the margin: auto which centres a modal dialog and its inner spacing, so both dialogs opened in the top-left corner with their content against the border.
…idden fix(own-tokens): keep the closed token and deprecation dialogs hidden
Contributor
Quality Report — ConductionNL/thematiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| test-fonts | ✅ | ||||
| test-token-set-coverage | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: this pull request comes from a release or sync branch, which carries only version strings. E2E runs on the promotions. | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-05 13:14 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
betaheld 3 commit(s)developmentdid not — release version bumps committed onto the branch the release ran from, and anything else that arrived out of band. Left unreconciled, both branches change the version file independently and the nextdevelopment→betapromotion conflicts on it.1 file(s) change. A 0-file result is the normal and correct outcome once the content has already reached
developmentby other means — recording the ancestry is the payload. Without it the merge base never moves and the next promotion conflicts exactly as before.Version files were resolved to
development's side, whose line is ahead of the released one, so this never moves a version backwards. Any conflict outside them aborts the merge for a human instead.Opened by fleet-back-merge.yml, using the algorithm
release.ymlalready applies to its ownsync/*-to-developmentpull requests.