docs(parity): corrections round 8, 4 rows re-read against their issues - #699
Merged
Merged
Conversation
Contributor
Quality Report — ConductionNL/thematiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it. | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-28 04:46 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections round 8 re-reads parity matrix rows against the functional issues the OpenSpec pass filed on 27 and 28 September. Only
openspec/parity/capabilities.jsonchanges. Every cited file and line was read at the development tipfd992ea9, and none of the cited files changed after the issues were filed.lib/Service/CustomOverridesService.php:232-237writes every override into one:rootblock with!important(:249-278). Nextcloud core declares the chosen theme's colours onbody[data-theme-dark], so a user who picked the dark theme never inherits an edited colour. The edits persist, but they do not apply to everyone.Rows on the list that keep their rating (evidence sentence and note added):
lib/Service/DesignTokensMapper.php:57acceptssrgb-linearand:644-652scales it without the transfer function and dropsalpha. The claim holds, but the upload and mapping still work for srgb hex and component colours and every other token type, soyesstays.lib/Service/ContrastService.php:245-263reads no alpha, solib/Service/DarkPaletteService.php:314-321derives translucent colours as opaque hex and skips 8-digit hex. The claim holds, but the dark variant is still derived for every opaque colour token, soyesstays.--animation-quick(lib/Service/TokenRegistry.php:232-233), the theme transitions read--nldesign-animation-quick(css/systems/nldesign/theme.css:382, mapped one way only atcss/systems/nldesign/overrides.css:212-213). The claim holds.partialalready reflects two untyped duration tokens and no easing token, so it stays.Checks:
--strict: 190 rated rows, 0 pending, 6 systems; one finding, theunknown-cellscensus (89 cells); schema errors 0. Output before and after is identical.thematiq,built.evidenceandnote.npm ciexit 0,lintexit 0,formatexit 0,check:manifestexit 0,test:l10nexit 0.🤖 Generated with Claude Code