Skip to content

docs(parity): corrections round 8, 4 rows re-read against their issues - #699

Merged
rubenvdlinde merged 1 commit into
developmentfrom
parity/corrections-8
Sep 28, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
parity/corrections-8

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Corrections round 8 re-reads parity matrix rows against the functional issues the OpenSpec pass filed on 27 and 28 September. Only openspec/parity/capabilities.json changes. Every cited file and line was read at the development tip fd992ea9, and none of the cited files changed after the issues were filed.

row before after issue what the issue shows at fd992ea
aut-overrides-persist thematiq: yes thematiq: partial #698 lib/Service/CustomOverridesService.php:232-237 writes every override into one :root block with !important (:249-278). Nextcloud core declares the chosen theme's colours on body[data-theme-dark], so a user who picked the dark theme never inherits an edited colour. The edits persist, but they do not apply to everyone.

Rows on the list that keep their rating (evidence sentence and note added):

Checks:

  • parity-verify --strict: 190 rated rows, 0 pending, 6 systems; one finding, the unknown-cells census (89 cells); schema errors 0. Output before and after is identical.
  • Row diff: style unchanged, no top-level change, no row order change, only the four rows above, only thematiq, built.evidence and note.
  • node v24.11.1, npm 11.19.1: npm ci exit 0, lint exit 0, format exit 0, check:manifest exit 0, test:l10n exit 0.
  • composer check:strict: not run, no lane has a bare-clone run that finishes, and this PR changes only the matrix JSON, which no PHP gate reads.

🤖 Generated with Claude Code

@rubenvdlinde
rubenvdlinde merged commit 551954e into development Sep 28, 2026
32 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/thematiq @ 6866111

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
format ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 2/2
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it.
Newman ✅
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test.
Hydra gates ✅

Quality workflow — 2026-09-28 04:46 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant