fix(theme): time the theme's transitions with the names the token editor sets - #704
Merged
rubenvdlinde merged 1 commit intoSep 28, 2026
Merged
Conversation
…tor sets The editor writes --animation-quick and --animation-slow, while theme.css timed its buttons, links and inputs with --nldesign-animation-quick, which the editor never sets. overrides.css only maps the nldesign name onto the Nextcloud name, so the admin's speed never reached those transitions and the page ran two speeds. theme.css now reads --animation-quick, which overrides.css still feeds from the set's --nldesign-animation-quick when no override is saved. Fixes #697
Contributor
Quality Report — ConductionNL/thematiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-28 15:36 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animation speeds set in the token editor did not reach the theme's own transitions.
The defect
The editor offers
--animation-quickand--animation-slowand writes those names.css/systems/nldesign/theme.csstimed its buttons, links and inputs withvar(--nldesign-animation-quick), which the editor never sets, andoverrides.cssonly maps the nldesign name onto the Nextcloud name. So "Animation quick" at 2s changed Nextcloud's own components while the theme's transitions stayed at 100ms, and the page ran two speeds.The test that was red
tests/Unit/MotionTokensReachTransitionsTest.phpreads every custom property atransitionoranimationintheme.cssuses and asks the realTokenRegistrywhether the editor can set it. On developmenttestEveryThemeTransitionReadsAnEditableMotionTokenfailed on--nldesign-animation-quick.testTheSetSpeedStillFeedsTheNextcloudNamesguards the mapping the fix relies on.The fix
The eight transitions in
theme.cssreadvar(--animation-quick). With no override saved,overrides.cssstill sets--animation-quickfrom the set's--nldesign-animation-quick, so the default stays 100ms; an editor override now reaches Nextcloud's components and the theme's transitions alike. A side effect: Nextcloud's reduced-motion theme sets--animation-quick: 0, which these transitions now follow too.The typed motion tokens, the renamed editor rows and the repair step in
authoring-token-value-typestasks 1.3, 2.4 and 2.5 are not part of this change; this is the smaller fix of the one name that did not line up. For a user who picked a theme explicitly, a:rootoverride still loses to core'sbodydeclarations; that is #698.Verified
composer check:strict: exit 0 (itstest:allskips in a bare clone, so PHPUnit ran separately).lib/privateon the autoloader: 870 tests, the same 11 errors and 7 failures as on development (missing Symfony and server classes outside a Nextcloud tree).npm run lint,format,test:l10n,check:l10n-js,check:manifest,test:unit,test:guest-css,test:component-scopes: all exit 0.--scope-to-diff: exit 0.Fixes #697