Skip to content

ben/use for test #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bencheng21 wants to merge 1 commit into from
Closed

ben/use for test #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/connector/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func New(ctx context.Context, ghc *cfg.Github, appKey string) (*GitHub, error) {
}
installation, resp, err := findInstallation(ctx, appClient, ghc.Orgs[0])
if err != nil {
return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation")
return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation hello")
Comment on lines 276 to +278
Copy link

@coderabbitai coderabbitai bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove the stray “hello” suffix from the error message.

This looks accidental and may degrade UX or break tests/log parsing that expect a stable error string (Line 278).

🧹 Suggested fix 
-		if err != nil {
-			return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation hello")
-		}
+		if err != nil {
+			return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation")
+		}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
installation, resp, err := findInstallation(ctx, appClient, ghc.Orgs[0])
if err != nil {
return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation")
return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation hello")
installation, resp, err := findInstallation(ctx, appClient, ghc.Orgs[0])
if err != nil {
return nil, wrapGitHubError(err, resp, "github-connector: failed to find app installation")
🤖 Prompt for AI Agents 
In `@pkg/connector/connector.go` around lines 276 - 278, The error string passed
to wrapGitHubError contains an accidental "hello" suffix; update the call in
connector.go where findInstallation(...) returns (see the variables
installation, resp, err) to remove the "hello" text so the message reads
"github-connector: failed to find app installation" (keep the wrapGitHubError
call and variables unchanged besides the message). Ensure you only change the
literal string passed to wrapGitHubError and run tests/log parsers to confirm no
other occurrences need the same fix.

}

token, err := getInstallationToken(ctx, appClient, installation.GetID())
Expand Down
Loading