Skip to content

Conversation

@gontzess
Copy link

@gontzess gontzess commented Jan 27, 2026

Summary

  • Upgrade baton-sdk from v0.2.99 to v0.7.4
  • Upgrade Go from 1.24.1 to 1.25.2
  • Update .golangci.yml to v2 format
  • Fix ST1019 duplicate imports lint error

CI Status

⚠️ Integration test fails due to missing CI secrets - no SQL Server instance configured in CI environment. This is a pre-existing infrastructure limitation, not introduced by this PR.

  • ✅ go-lint: PASS
  • ✅ go-test (ubuntu): PASS
  • ✅ go-test (windows): PASS
  • ❌ test: FAIL (missing SQL Server credentials)

Test plan

  • Lint passes
  • Unit tests pass
  • Integration test requires SQL Server credentials in CI

Summary by CodeRabbit

  • Dependencies

    • Go toolchain bumped to 1.25.2 and major dependency updates for improved stability and compatibility.
  • Chores

    • Internal cleanup of imports and code organization.
    • Internal account/connector-related API adjustments to align with updated dependencies (no user-facing behavior changes).

✏️ Tip: You can customize this high-level summary in your review settings.

@gontzess gontzess requested a review from a team January 27, 2026 16:11
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

The PR upgrades Go toolchain and multiple dependencies (notably github.com/conductorone/baton-sdk), removes redundant blank imports across connector files, updates resource call sites to use sdkResources, and changes a CreateAccount parameter type and adds a static interface assertion in server_user.go.

Changes

Cohort / File(s) Summary
Dependency & Toolchain Updates
go.mod
Go toolchain upgraded from 1.24.1 to 1.25.2; github.com/conductorone/baton-sdk bumped v0.2.99 → v0.7.4; github.com/stretchr/testify bumped v1.10.0 → v1.11.1; several indirect dependencies added/updated (e.g., semver/v3, purego, otter v2, gopsutil v4, golang.org/x/sys v0.38.0).
Redundant Import Removal
pkg/connector/connector.go, pkg/connector/database.go, pkg/connector/group.go, pkg/connector/server.go, pkg/connector/server_role.go, pkg/connector/server_user.go
Removed duplicate/blank underscore imports of github.com/conductorone/baton-sdk/pkg/annotations, consolidating to a single named import where applicable.
SDK Resource Reference Migration
pkg/connector/database_role.go
Replaced resource.NewRoleResourcesdkResources.NewRoleResource and resource.WithParentResourceIDsdkResources.WithParentResourceID; removed now-unused local resource imports.
Server user API & Static Assertion
pkg/connector/server_user.go
Added static type assertion: var _ connectorbuilder.AccountManagerLimited = (*userPrincipalSyncer)(nil); changed CreateAccount parameter type from *v2.CredentialOptions to *v2.LocalCredentialOptions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through modules, versions took flight,
I nudged blank imports out of sight,
Swapped resource names with a tidy cheer,
Adjusted a sig and left a type near,
A little rabbit’s patch—clean and light.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: upgrading baton-sdk to v0.7.4 and Go to 1.25.2, which are the primary objectives reflected in go.mod and throughout the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@gontzess gontzess force-pushed the task-sdk-upgrade-batch-7 branch 2 times, most recently from ba23f57 to 046abf5 Compare January 27, 2026 17:12
@gontzess gontzess changed the title chore: upgrade baton-sdk to v0.7.3 and Go to 1.25.2 Upgrade baton-sdk to v0.7.4 and Go to 1.25.2 Jan 27, 2026
@gontzess gontzess marked this pull request as draft January 27, 2026 18:59
@gontzess gontzess force-pushed the task-sdk-upgrade-batch-7 branch 3 times, most recently from 5f8d91c to 519671c Compare January 27, 2026 20:27
@gontzess gontzess force-pushed the task-sdk-upgrade-batch-7 branch from 519671c to 88baa0c Compare January 27, 2026 21:07
@gontzess gontzess marked this pull request as ready for review January 27, 2026 22:11
Updates the CreateAccount method signature to use v2.LocalCredentialOptions
instead of the deprecated v2.CredentialOptions, which was causing an "old
account manager interface implemented" error after the SDK upgrade to v0.7.4.
Also adds compile-time verification that userPrincipalSyncer implements the
AccountManagerLimited interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants