Crd-redesign #80
Open
Crd-redesign #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubebuilder create api --version v1alpha1 --kind GitTarget --resource --controller kubebuilder create api --version v1alpha1 --kind GitProvider --resource --controller
end2end tests never ran (and are not adjusted yet). The agent was happy to announce that the unit tests where working: but they where not converted yet. Yaml mistakes where made. It's an intersting world.
I must admit: it took some time, but it found almost all missing thing itself. The only shame is that the unittests are still not converted. It's now crunching to do that.
This was an expansive commit ($19,43). It tried to delete ssh_tests.ssh since it was said to be obsolete (I refused and asked it to convert, which it did). It actually did a good job on converting all the other resources, It fixed all linting mistakes, all tests are now running. It looks like a pretty good prorammer to me!
Now all things should be fixed, this was only $0,35 cents. It remains interesting how things are forgotten and need checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now all things should be fixed, this was only $0,35 cents.
It remains interesting how things are forgotten and need checks.
Description
Brief description of the changes in this PR.
Type of Change
Please delete options that are not relevant.
Testing
Checklist
Related Issues
Closes #(issue number)
Screenshots (if applicable)
Add screenshots to help explain your changes.
Additional Notes
Any additional information that reviewers should know.