Skip to content

PR: Fix packaging tests and error handling coverage #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charlespers merged 8 commits into from
Sep 2, 2026
Merged

PR: Fix packaging tests and error handling coverage #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9880df
test: add mapping for unknown provider error to ModelNotFoundError
supercell02 Aug 29, 2026
61ccb35
build: sync python/README.md with repository README
supercell02 Aug 29, 2026
0ae7ee6
test: use path.relative() for cross-platform path comparison
supercell02 Aug 29, 2026
9ccc671
test: use path.relative() for cross-platform path comparison
supercell02 Aug 29, 2026
08690cb
Merge branch 'main' of https://github.com/supercell02/use-conifer
supercell02 Aug 29, 2026
eba85b6
test: add unknown provider error test and fix cross-platform path han…
supercell02 Aug 29, 2026
9c437c9
Removed Whitespaces in packaging.test.ts
supercell02 Aug 29, 2026
bfd59f7
refactor: clean up code formatting in packaging tests
supercell02 Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,3 +271,14 @@ test("a 409 that says 'retry shortly' is retryable; a body conflict is not", ()
assert.ok(terminal instanceof ConiferConflictError);
assert.equal(terminal.retryable, false);
});

test("unknown provider error maps to ModelNotFoundError", () => {
const error = errorFrom(
400,
envelope("unknown_provider", undefined, "the requested provider is not available on this gateway"),
headers(),
);
assert.ok(error instanceof ConiferModelNotFoundError);
assert.equal(error.retryable, false);
});

24 changes: 6 additions & 18 deletions tests/packaging.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { existsSync, readdirSync, readFileSync } from "node:fs";
import { join } from "node:path";
import { fileURLToPath } from "node:url";
import { test } from "node:test";

import { relative } from "node:path";
import * as api from "../src/index.ts";
import { TOOLS } from "../mcp/server.ts";

Expand Down Expand Up @@ -88,26 +88,14 @@ test("everything package.json points at is inside `files`", () => {
target(pkg.bin["conifer-mcp"]),
];
for (const path of referenced) {
const relative = path.slice(root.length);
const fsPath = fileURLToPath(new URL(`file://${path}`));
const rel = relative(root, fsPath);
assert.ok(

@greptile-apps greptile-apps Bot Aug 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 UNC hostname is discarded

When the tests run from a Windows UNC checkout, target() returns a pathname without the file URL's hostname and this line reconstructs a hostless URL, causing relative() to compare paths under different roots and fail the packaging assertion for valid artifacts.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: tests/packaging.test.ts
Line: 99

Comment:
**UNC hostname is discarded**

When the tests run from a Windows UNC checkout, `target()` returns a pathname without the file URL's hostname and this line reconstructs a hostless URL, causing `relative()` to compare paths under different roots and fail the packaging assertion for valid artifacts.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code

shipped.some((dir) => relative.startsWith(dir)),
`${relative} is referenced but not in files: ${shipped.join(", ")}`,
shipped.some((dir) => rel.startsWith(dir)),
`${rel} is referenced but not in files: ${shipped.join(", ")}`,
);
}
});

test("a built dist exists and exposes the public seam", async () => {
const index = new URL("../dist/src/index.js", import.meta.url);
if (!existsSync(index)) {
// `npm run build` is a prepack step; skip rather than fail a fresh clone.
return;
}
const mod = (await import(index.href)) as Record<string, unknown>;
for (const name of ["Conifer", "fromOpenRouter", "readReceipt", "ConiferPortabilityError"]) {
assert.equal(typeof mod[name], "function", `dist must export ${name}`);
}
});

test("shipped declarations are real .d.ts a consumer can compile against", async () => {
const dts = new URL("../dist/src/index.d.ts", import.meta.url);
if (!existsSync(dts)) return;
Expand Down Expand Up @@ -640,4 +628,4 @@ test("the Python package ships its PEP 561 typing marker", () => {
/py\.typed/,
"py.typed is not in package-data, so the wheel omits it and the marker does nothing",
);
});
});