docs(o11y-coroot): drop stale references to removed examples from ARCHITECTURE.md#39
Conversation
…HITECTURE.md The production-ready and runn examples were removed from main on 2026-06-16 (#24). ARCHITECTURE.md still referenced them in the OTLP routing rationale, the image table, the port-conflict analysis, and the file-structure sketch. Rewrites those spots to match the shipped example: both services build from the local service/ directory, the collector version matches docker-compose (0.120.0), and the structure sketch shows the real tree. Follow-up promised in #23.
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates o11y-coroot/ARCHITECTURE.md documentation to reflect a revised Docker-compose setup: default OTLP endpoint retention, an updated collector image version, build contexts referencing a local service/ directory, simplified port conflict notes, and a restructured example directory tree. ChangesArchitecture documentation revision
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@o11y-coroot/ARCHITECTURE.md`:
- Around line 153-158: Update the 8080 port conflict note in ARCHITECTURE.md so
it does not imply the clash is avoided just because the examples use separate
Docker networks. Clarify in the o11y-coroot table that Coroot UI on 8080
conflicts with with-events-redpanda’s Redpanda Console on the host when both
stacks run together, and state the safe cases using the existing port table
entry: run the examples one at a time or remap one side’s host port.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 460a6eec-a0bd-4f9b-b64c-7822d4c8cd10
📒 Files selected for processing (1)
o11y-coroot/ARCHITECTURE.md
…s regardless of docker networks (CodeRabbit review)
|
Addressed: the 8080 row and the section conclusion now state explicitly that isolated docker networks do not prevent host port collisions — 8080 is safe only when examples run one at a time, otherwise remap one side (e.g. |
Summary
Cleanup promised in #23: the
production-readyandrunnexamples were removed frommainon 2026-06-16 (#24), buto11y-coroot/ARCHITECTURE.mdstill referenced them in ~10 places. This PR rewrites those spots to match the shipped example:production-ready— states the actual property (the services' defaultotel-collector:4318endpoint works unchanged).service/build context (whatdocker-compose.ymlactually does); the OTel Collector version now matches compose (0.120.0).with-events-redpandaon 8080) kept.service/directory built twice,clickhouse-users.xml,scripts/generate-traffic.sh); the symlink/copy note referencingproduction-readyremoved.No behavior changes — documentation only.
Related
docker build .anddocker compose upfail (no application code) #23 (the promised follow-up)🤖 Generated with Claude Code
https://claude.ai/code/session_015Sp8jYmRXyvUmsErDuNJvt
Summary by CodeRabbit