Transmission power description printed by printBoardParameters is valid only for te 30D model#12
Open
paulignari wants to merge 1 commit intoConnorKirkpatrick:masterfrom
Open
Conversation
Author
|
I noticed now that the same problem is present in function getPower, where is more difficult to pick the right number |
Owner
|
According to the Ebyte data sheet, there may be a way to query the module type (per section 7.1.3 from here https://www.cdebyte.com/pdf-down.aspx?id=4221 ) It would be worth investigating this mechanism to avoid providing multiple values if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While setting the transmission power is correct for both models (30D with maximum 30dBm transmission power and 22D with maximum 22dBm transmission power), when printing info in printBoardParameters only values for 30D model are displayed.
As there is not any way to check which board is in use, I propose to display both values and let the owner to pick the right one.