Fix superset-worker healthcheck path in Service Update Override - #167
Merged
Conversation
HealthCheck must nest under TaskTemplate.ContainerSpec,
we had wrongly put it directly under TaskTemplate.
TaskTemplate:
ContainerSpec:
HealthCheck: ["None"]
Extracts a `disable_healthcheck()` pure function for reuse & testing
rudokemper
approved these changes
Jul 30, 2026
Contributor
Author
How I convinced myself this is rightI ran they also had HealthCheck in the correct indentation level of SUO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background worker processes do not expose a web port and would fail a healthcheck from docker. This has led to boot-loops on the workers, and so we (previously) attempted to disable the healtcheck on worker processes, using Service Update Override.
The problem is we had got the syntax wrong!
HealthCheck must nest under TaskTemplate.ContainerSpec. We had wrongly put it directly under TaskTemplate.
What I changed and why
Extracts a
disable_healthcheck()pure function for reuse & testingAdds tests.
LLM use disclosure
Claude code made the code changes, which I reviewed. I wrote the documentation and PR description.