Skip to content

Add view button shows on empty state - #575

Merged
rudokemper merged 3 commits into
mainfrom
rk/add-dataset-view-available-on-empty-state
Aug 5, 2026
Merged

Add view button shows on empty state#575
rudokemper merged 3 commits into
mainfrom
rk/add-dataset-view-available-on-empty-state

Conversation

@rudokemper

Copy link
Copy Markdown
Member

Goal

The Add button was gated on accessibleViews.length, so it disappears in the empty state:

image

What I changed and why

  • v-if="accessibleViews.length || shouldShowConfigLink"
  • e2e test

How I convinced myself this is right

What I'm not doing here

LLM use disclosure

Cursor

@rudokemper rudokemper self-assigned this Aug 5, 2026
@rudokemper
rudokemper force-pushed the rk/add-dataset-view-available-on-empty-state branch from 39d910d to 62908df Compare August 5, 2026 20:52
@rudokemper
rudokemper force-pushed the rk/add-dataset-view-available-on-empty-state branch from 62908df to fadf932 Compare August 5, 2026 20:54
@rudokemper
rudokemper merged commit 2941102 into main Aug 5, 2026
3 checks passed
@rudokemper
rudokemper deleted the rk/add-dataset-view-available-on-empty-state branch August 5, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants