Refactor file I/O to use context managers and fix bare excepts#19
Closed
avinxshKD wants to merge 1 commit intoControlCore-Project:mainfrom
Closed
Refactor file I/O to use context managers and fix bare excepts#19avinxshKD wants to merge 1 commit intoControlCore-Project:mainfrom
avinxshKD wants to merge 1 commit intoControlCore-Project:mainfrom
Conversation
Author
|
@pradeeban pls let me know if this makes sense, if adjustment needed pls let me know thanks |
Member
|
Actually, you shouldn't be making code enhancements and refactors here. This is a minimal tutorial-style repository. If something is explicitly broken (i.e., it simply is not working), then fix it. Otherwise, please use your effort on fixing these respective files in the concore repository instead. We otherwise are going to be committing the same fixes twice - once in concore and then in concore-lite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced bare except: blocks with specific exceptions and added context managers for file operations that need explicit cleanup
closes #12