feat(contracts): implement notification revocation mechanism and auth safeguards (#176) - #208
Merged
Abd-Standard merged 1 commit intoJun 24, 2026
Conversation
|
@Abdullahi-Code9 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176
Summary
Addresses #176 by adding a secure notification revocation mechanism to the core smart contract layer. This feature allows authorized entities (the notification creator or the contract admin) to permanently invalidate scheduled notifications before a recipient interacts with them, keeping a transparent on-chain history for auditing.
Key Changes
ScheduledNotificationintypes.rsto track revocation vectors viarevoked_by: Option<Address>andrevoked_at: Option<u64>.autoshare_logic.rs. Unauthorized revoke attempts trigger a customError::NotAuthorizedToRevokeerror code.Error::NotificationRevoked.NotificationRevokedevent matrix toevents.rsso that downstream indexers can efficiently detect revocations.revocation_test.rsto safely includeextern crate std;for test boundaries, running 14 comprehensive functional scenarios capturing execution paths, edge cases, and permission overrides.Verification Results
Verified implementation boundaries and event emissions against structural state changes via local Cargo framework.
cargo test revocationResult: 14 passed, 0 failed.