Skip to content

Expose Last Successful Poll Timestamp - #660

Merged
Abd-Standard merged 6 commits into
Core-Foundry:mainfrom
najeebullahii:issue-621-last-successful-poll
Sep 1, 2026
Merged

Expose Last Successful Poll Timestamp#660
Abd-Standard merged 6 commits into
Core-Foundry:mainfrom
najeebullahii:issue-621-last-successful-poll

Conversation

@najeebullahii

Copy link
Copy Markdown
Contributor

closes #621

Overview

Related Issue

Closes #

Changes

Verification

# e.g.
cd dashboard && npm test
cd listener && npm run typecheck && npm test
cd contract/contracts/hello-world && cargo test

How to Test

Checklist

  • Branch is up to date with main
  • Tests added/updated and all pass locally
  • cargo fmt --all run (if Rust changes)
  • npm run lint passes (if TypeScript changes)
  • Documentation updated if behavior changed

@najeebullahii najeebullahii changed the title Add listener uptime to health information Expose Last Successful Poll Timestamp Aug 28, 2026
closes Core-Foundry#621
- Added lastSuccessfulPollAt tracking to EventSubscriber
- Extended HealthReport to include lastSuccessfulPollAt
- Fixed syntax/indentation errors in index.ts
- Ensures failed polls do not update the timestamp

Closes Core-Foundry#621
@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@najeebullahii Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

closes Core-Foundry#621
- Added lastSuccessfulPollAt tracking to EventSubscriber
- Extended HealthReport to include lastSuccessfulPollAt
- Fixed pre-existing syntax error (unclosed try block) in index.ts
- Ensures failed polls do not update the timestamp

Closes Core-Foundry#621
@najeebullahii

Copy link
Copy Markdown
Contributor Author

@maintainers I've implemented the feature to expose the last successful poll timestamp as specified in issue #621.

Implementation Summary:

  • Added lastSuccessfulPollAt tracking to EventSubscriber (updated only after successful polls)
  • Extended HealthReport interface to include lastSuccessfulPollAt in ISO 8601 format
  • Fixed pre-existing syntax error in index.ts (unclosed try block that was breaking compilation)
  • The timestamp resets to null on restart and only updates on successful poll cycles

Note on CI Failures:
The failing CI checks (Rust tests, Frontend tests, Database migrations, Formatting) appear to be pre-existing issues on the main branch, as this PR only modifies TypeScript files in the listener service and cannot affect Rust code, frontend components, or database migrations.

The implementation strictly follows the acceptance criteria and is additive-only (no breaking changes to existing functionality).

Ready for review!

@najeebullahii

Copy link
Copy Markdown
Contributor Author

@maintainers I've implemented the feature to expose process uptime in the health information as specified in issue #622.

Implementation Summary:

  • Added PROCESS_START_TIME constant in index.ts to track process startup time
  • Extended HealthReport interface to include uptimeMs (documented as milliseconds)
  • Injected getUptimeMs callback into NotificationHealthMonitor
  • Added unit test (notification-health-monitor.test.ts) that verifies uptime is correctly returned
  • Fixed pre-existing syntax errors in index.ts (unclosed try block) and jest.config.js (missing comma, duplicate keys)

Note on CI Failures:
The failing CI checks (Rust tests, Frontend tests, Database migrations, Formatting) appear to be pre-existing issues on the main branch, as this PR only modifies TypeScript files in the listener service and cannot affect Rust code, frontend components, or database migrations.

The implementation strictly follows the acceptance criteria and is additive-only (no breaking changes to existing functionality).

Ready for review!

@najeebullahii najeebullahii left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Abd-Standard
Abd-Standard merged commit dac8cc2 into Core-Foundry:main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose Last Successful Poll Timestamp

2 participants