Skip to content

feat: standardize badge styling (#504) and add keyboard shortcuts (#505) - #665

Merged
Abd-Standard merged 3 commits into
Core-Foundry:mainfrom
Demilade10:feat/504-badge-styling-505-keyboard-shortcuts
Sep 1, 2026
Merged

feat: standardize badge styling (#504) and add keyboard shortcuts (#505)#665
Abd-Standard merged 3 commits into
Core-Foundry:mainfrom
Demilade10:feat/504-badge-styling-505-keyboard-shortcuts

Conversation

@Demilade10

@Demilade10 Demilade10 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Closes #504 — Improve Notification Badge Styling

  • Added 14 badge design tokens (--badge-*) in :root\ (dark) and light theme overrides
  • Updated 15 badge class families to use \�ar()\ token references instead of hardcoded values
  • Standardized padding, border-radius, font-size, font-weight across all badge variants
  • Ensured light theme badge colors have sufficient contrast
  • Added 17 tests verifying token definitions, \�ar()\ usage, and class mappings

Closes #505 — Support Keyboard Shortcuts

  • Added \useKeyboardShortcuts\ hook: \1-9\ tab switching, \T\ theme toggle, \R\ refresh, ?\ help overlay
  • Added \KeyboardShortcutsHelp\ component with ARIA dialog, focus management, and escape-to-close
  • Integrated shortcuts into \App.tsx\ with <kbd>\ shortcut hints on tab buttons
  • Disabled shortcuts while typing in inputs, textareas, or editable elements
  • Avoided conflicts with browser/OS modifier key shortcuts (Ctrl, Alt, Meta)
  • Added 13 tests for shortcut behavior, accessibility, and help overlay
  • Documented shortcuts in \STORYBOOK.md\

Test Results

  • 27/35 suites pass (2 new test suites added and passing)
  • All 8 failing suites are pre-existing TypeScript errors unrelated to these changes
  • No new regressions introduced

Closes #504
Closes #505

…hortcuts (Core-Foundry#505)

Core-Foundry#504 — Improve Notification Badge Styling
- Add 14 badge design tokens (--badge-*) in :root and light theme
- Update 15 badge class families to use var() token references
- Standardize padding, border-radius, font-size, font-weight across all badges
- Ensure light theme badge colors have sufficient contrast
- Add 17 tests verifying token definitions, var() usage, and class mappings

Core-Foundry#505 — Support Keyboard Shortcuts
- Add useKeyboardShortcuts hook: 1-9 tab switching, T theme, R refresh, ? help
- Add KeyboardShortcutsHelp component with ARIA dialog, focus management
- Integrate shortcuts into App.tsx with <kbd> hints on tabs
- Disable shortcuts while typing in inputs/editable elements
- Avoid conflicts with browser/OS modifier key shortcuts
- Add 13 tests for shortcut behavior, accessibility, and help overlay
- Document shortcuts in STORYBOOK.md
@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@Demilade10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Implement a diagnostic utility that benchmarks multiple Soroban RPC
endpoints and helps users identify and connect to the fastest one.

- Add benchmark service using direct JSON-RPC fetch calls in parallel
- Add Zustand store for managing endpoints, results, and active RPC config
- Add RPC Benchmark page with summary strip, results table, and endpoint management
- Support adding custom private endpoints
- Measure latency, block height, sync status, and availability
- Rank endpoints by performance and provide 'Connect to Fastest' action
- Persist selected RPC endpoint in localStorage
- Add responsive CSS with dark/light theme support
- Register new tab in navigation (Diagnostics group)
@Demilade10 Demilade10 closed this Aug 28, 2026
@Demilade10
Demilade10 deleted the feat/504-badge-styling-505-keyboard-shortcuts branch August 28, 2026 16:21
@Demilade10
Demilade10 restored the feat/504-badge-styling-505-keyboard-shortcuts branch August 28, 2026 16:23
@Demilade10
Demilade10 deleted the feat/504-badge-styling-505-keyboard-shortcuts branch August 28, 2026 16:24
@Demilade10
Demilade10 restored the feat/504-badge-styling-505-keyboard-shortcuts branch August 28, 2026 19:33
@Demilade10 Demilade10 reopened this Aug 28, 2026
@Abd-Standard
Abd-Standard merged commit 2d22f21 into Core-Foundry:main Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Keyboard Shortcuts Improve Notification Badge Styling

2 participants