feat(logger): add centralized sensitive field redaction to logs (#691) - #731
Open
ravendevhub wants to merge 1 commit into
Open
feat(logger): add centralized sensitive field redaction to logs (#691)#731ravendevhub wants to merge 1 commit into
ravendevhub wants to merge 1 commit into
Conversation
…-Foundry#691) - Define sensitive key patterns (passwords, secrets, auth tokens, api keys, webhook URLs) - Redact embedded Bearer tokens, Discord webhook URLs, and Stellar secret keys from strings - Sanitize Error objects, nested causal chains, and stack traces before log emission - Add test suite in redact.test.ts and documentation in docs/SENSITIVE_FIELD_REDACTION.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #691 by implementing a centralized redaction policy and sanitizer engine (
listener/src/utils/redact.ts) ensuring API keys, passwords, webhook URLs, bearer tokens, and Stellar secret keys are systematically sanitized before being emitted to log outputs.Changes
listener/src/utils/redact.ts):password,secret,authorization,api_key,webhook_url, etc.).Bearer [REDACTED]), Discord webhooks (https://discord.com/api/webhooks/[REDACTED_WEBHOOK_URL]), and Stellar secret keys (S[REDACTED_STELLAR_SECRET_KEY]).listener/src/utils/logger.ts):redactSensitiveDatabefore formatting.redact.test.tsverifying object, string, error, and circular reference redactions.docs/SENSITIVE_FIELD_REDACTION.md.Acceptance Criteria