feat(api): add request size protection middleware (#688) - #746
Open
ravendevhub wants to merge 1 commit into
Open
feat(api): add request size protection middleware (#688)#746ravendevhub wants to merge 1 commit into
ravendevhub wants to merge 1 commit into
Conversation
- Enforce configurable request body size limits with HTTP 413 Payload Too Large - Inspect Content-Length header for fast rejection - Monitor and abort streaming chunked transfers to prevent memory exhaustion - Add test suite in request-size-limiter.test.ts and docs in docs/REQUEST_SIZE_PROTECTION.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #688 by introducing an API request size protection middleware (
listener/src/api/request-size-limiter.ts) that enforces configurable byte limits on incoming payloads, fast-rejects oversizedContent-Lengthheaders, and pauses/destroys streaming data to prevent memory exhaustion and DoS attacks.Changes
listener/src/api/request-size-limiter.ts):Content-Lengthheaders and incoming stream chunks againstmaxSizeBytes.PAYLOAD_TOO_LARGEerror responses.listener/src/api/request-size-limiter.test.ts):docs/REQUEST_SIZE_PROTECTION.md):Acceptance Criteria