fix(figma): guard localStorage access in the srcdoc sandbox - #22
Merged
Conversation
The bundled editor runs inside Figma's about:srcdoc frame, where reading window.localStorage throws SecurityError. The save rate limiter read it on every push and threw before the save ran, so clicking Save did nothing. Access now falls back to an in-memory store when the browser blocks it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
The bug
Saving from the Figma plugin did nothing and logged
SecurityError: Failed to read the 'localStorage' property from 'Window'. The plugin runs the bundled editor inside Figma's sandboxedabout:srcdocframe, where readinglocalStorageis denied.The fix
The save path's rate limiter read
localStorageon every push and threw before the save ran, so the click was lost. All three wwwlocalStoragetouch points now go through asafeLocalStoragewrapper that falls back to an in-memory store when the browser blocks access. On the web nothing changes. Scoped to the www editor that Figma bundles; the separate wp save path is not sandboxed and is untouched.Verification
A new test denies
localStoragethe way the sandbox does. It fails without the fix and passes with it.