Standardize the supported website deployment path - #6
Merged
Conversation
jaavid
marked this pull request as ready for review
August 6, 2026 10:21
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1
What changed
npm run buildthe canonical Next.js static production build*:sitesinternal toolingtest:sitesRoot cause fixed
The previous rendered-HTML test imported
dist/server/index.js, coupling the production gate to the internal Vinext/Sites Worker artifact. The supported Next.js static build correctly producesout/index.html, so the old test failed despite a successful production build.The production test now validates
out/index.html; the Worker-specific test remains available only throughtest:sites.Validation
npm ci— passednpm run lint— passed with one pre-existing@next/next/no-img-elementwarningnpm test— Next.js 16.2.11 build/typecheck/static export passed; 1/1 static HTML test passedhttps://github.com/CoreLinkPlatform/website/actions/runs/31103313713
After merge, retain the exact-main Deploy to GitHub Pages run before closing WEB-01.