Prevent issue watcher overwrites across colliding repo slugs#142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-technical summary
New GitHub issue watcher installs no longer overwrite each other when two different repositories collapse to the same normalized slug. This matters now because the watcher flow is meant to be reusable across repos, and silent collisions break that promise by replacing one user-visible Cycle with another.
Technical summary
owner/repoidentity when generating new watcher job names inlib/clauck~/.clauckRelevant intent:
INTENT.mdby ensuring repository identity is preserved in durable watcher artifacts instead of being lost to lossy normalizationTests:
python3 -m unittest tests.test_clauck_reportpython3 -m unittest discover testsBreaking changes:
Additional notes
Trade-offs:
Deferred follow-up:
Remaining gap:
Closes #120.